-
Couldn't load subscription status.
- Fork 2.4k
Updates to Web Speech API data #27901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some preliminary remarks, didn't check everything yet.
Overall, I find this PR hard to review. Could you please consider splitting it up? I think it would make sense to separate:
- the new permission
- the new phrase-related features
- the Firefox fixes
- cleaning up the SpeechRecognitionEvent
Co-authored-by: Claas Augner <[email protected]>
OK, I mean, it's not even that big a set of changes, and they are all related, more or less. Can you not just concentrate on one of those bullets per day until they are all done? I'm happy to wait a few days. |
api/SpeechGrammarList.json
Outdated
| "name": "media.webspeech.recognition.enable", | ||
| "value_to_set": "true" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you probably want me to update the support data for each one of these interfaces and their constructors to something like
"firefox": [
{
"version_added": "142",
"flags": [
{
"type": "preference",
"name": "media.webspeech.recognition.enable",
"value_to_set": "true"
}
]
},
{
"prefix": "webkit",
"version_added": "33"
}
]
But, which browser version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, only the interfaces and the constructors, with the same version and flags:
[
{
"version_added": "142",
"flags": [
{
"type": "preference",
"name": "media.webspeech.recognition.enable",
"value_to_set": "true"
}
]
},
{
"version_added": "142",
"flags": [
{
"type": "preference",
"name": "media.webspeech.recognition.enable",
"value_to_set": "true"
}
],
"prefix": "webkit"
}
]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned above, Firefox also supports SpeechRecognition behind the pref, confirmed with https://mdn-bcd-collector.gooborg.com/tests/api/SpeechRecognition in Firefox 143.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've added Firefox 143 support for SpecchRecognition and all relevant subfeatures.
Co-authored-by: Claas Augner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addendum: Firefox also supports SpeechGrammar only since 142 behind the pref.
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `SpeechRecognition` API. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.15.1). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/SpeechRecognition Additional Notes: This effectively reverts the parts of mdn#27901 that relate to on-device speech recognition.
…lly` (#28112) Update Chromium data for SpeechRecognition API This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `SpeechRecognition` API. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.15.1). Additional Notes: This effectively reverts the parts of #27901 that relate to on-device speech recognition.

Summary
This PR makes several changes to the Web Speech API data:
"standard_track": falsebut the others should all be"standard_track": true. All of them should be"deprecated": true.Test results and supporting details
Related issues