Skip to content

Ensure that version_removed: false does not get generated by mirroring #27451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

Ensure that version_removed: false does not get generated by mirroring #27451

merged 2 commits into from
Aug 1, 2025

Conversation

@queengooborg
Copy link
Contributor

This PR updates the mirroring script to check if the end result of version_removed is false, and if so, delete the key so that it is not generated in the final build output. Fixes #27437.

@github-actions github-actions bot added infra Infrastructure issues (npm, GitHub Actions, releases) of this project scripts Issues or pull requests regarding the scripts in scripts/. size:xs [PR only] 0-6 LoC changed labels Jul 30, 2025
@github-actions
Copy link
Contributor

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@queengooborg queengooborg requested a review from Elchi3 July 31, 2025 02:11
@Elchi3
Copy link
Member

Elchi3 commented Jul 31, 2025

Do you know why it gets generated in the first place?

@queengooborg
Copy link
Contributor Author

I do, yes -- it is set to false if the upstream browser has a version_removed that doesn't correspond to a downstream browser's release. Since the version mapping is the same for version_added, this makes sense!

(Note: in the previous BCD call, Daniel had said that version_removed: true was getting generated, in which I replied that I didn't know how that was happening. But false, on the other hand, totally makes sense.)

@Elchi3
Copy link
Member

Elchi3 commented Jul 31, 2025

it is set to false if the upstream browser has a version_removed that doesn't correspond to a downstream browser's release.

Can you add that as a code comment?

@github-actions github-actions bot added size:s [PR only] 7-24 LoC changed and removed size:xs [PR only] 0-6 LoC changed labels Jul 31, 2025
@Elchi3 Elchi3 merged commit 5b3e913 into main Aug 1, 2025
11 of 12 checks passed
@Elchi3 Elchi3 deleted the version_removed_mirroring branch August 1, 2025 09:31
@ddbeck ddbeck mentioned this pull request Aug 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees

No one assigned

Labels

infra Infrastructure issues (npm, GitHub Actions, releases) of this project scripts Issues or pull requests regarding the scripts in scripts/. size:s [PR only] 7-24 LoC changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Schema forbids booleans for version_removed, but data contains false values

2 participants

@queengooborg @Elchi3