Skip to content

feat: Set compiled function name #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2019
Merged

feat: Set compiled function name #466

merged 2 commits into from
Oct 30, 2019

Conversation

ExE-Boss
Copy link
Collaborator

This sets the name property for the compiled function, so that it matches opts.filename without the file extension.

I also made it so that the default name would be anonymous instead of returnedFn, to match what the Function constructor sets the name to.

@ExE-Boss ExE-Boss requested a review from mde October 20, 2019 16:29
@ExE-Boss ExE-Boss self-assigned this Oct 20, 2019
@ExE-Boss ExE-Boss added the enhancement New feature or request label Oct 20, 2019
@mde mde merged commit 12a7541 into mde:master Oct 30, 2019
@mde
Copy link
Owner

mde commented Oct 30, 2019

LGTM. Thank you for this!

@ExE-Boss ExE-Boss deleted the feat/set-function-name branch October 30, 2019 11:17
This was referenced Nov 22, 2019
Closed
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 18, 2019
Open
This was referenced Jan 23, 2020
Open
Merged
This was referenced Feb 1, 2020
Merged
Merged
Open
This was referenced Feb 23, 2020
Open
Open
This was referenced Mar 17, 2020
Open
Merged
Merged
Merged
This was referenced Mar 28, 2020
Open
Open
This was referenced Apr 9, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 18, 2020
Merged
This was referenced May 5, 2020
Open
Open
This was referenced Jun 4, 2024
Open
Open
@javascript-benchmark javascript-benchmark mentioned this pull request Jul 6, 2024
Open
@bgustudentunion bgustudentunion mentioned this pull request Jul 18, 2024
Open
@sumitmishra04 sumitmishra04 mentioned this pull request Jul 27, 2024
Open
@SwethaPodhila SwethaPodhila mentioned this pull request Aug 23, 2024
Open
This was referenced Sep 10, 2024
Open
Open
@yash509 yash509 mentioned this pull request Sep 16, 2024
Open
@srom23 srom23 mentioned this pull request Sep 22, 2024
Open
@kazup01 kazup01 mentioned this pull request Sep 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mde mde Awaiting requested review from mde

Assignees

@ExE-Boss ExE-Boss

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ExE-Boss @mde