Skip to content

Conversation

@plarocque4
Copy link

@plarocque4 plarocque4 commented Mar 6, 2024

Describe your changes

Add support for Addyi, a medication that does not have ETASU and only has a medication guide.
These changes are needed to support the no_etasu branch in rems-admin.

Issue ticket number and Jira link

REMS-616

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@jtquach1 jtquach1 self-assigned this Mar 7, 2024
@jtquach1
Copy link

jtquach1 commented Mar 7, 2024

Nothing wrong with the resource, it's code in the rems-admin's src/hooks/hookResources.ts that causes the Bad Request to happen.

image
image

image

Running everything on the latest dev branch (except test-ehr on this, and using my existing Docker containers/images for rems-setup's Mongo and Keycloak instances whose configs haven't changed).

@jtquach1
Copy link

jtquach1 commented Mar 7, 2024

Upon looking up '2183126' (Turalio's code) I also see that within rems-admin, it's referenced in src/fhir/utilities.ts for the FhirUtilities.prepopulateDB method as well, so if Addyi's not added in there then it won't show up in rems-admin when you click the reset REMS admin button in the settings panel

Copy link

@jtquach1 jtquach1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes in test-ehr are fine, but rems-admin might need a separate PR to fulfill this ticket- also see my comments above (that I forgot to put in this review)

@jtquach1
Copy link

jtquach1 commented Mar 7, 2024

nvm saw the other pr

@jtquach1 jtquach1 merged commit b43f356 into dev Mar 7, 2024
@jtquach1 jtquach1 deleted the no_etasu branch March 7, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants