Skip to content

Conversation

@smalho01
Copy link
Collaborator

@smalho01 smalho01 commented Sep 8, 2023

Describe your changes

Change the dev runner to include the new string to look for to run cradle load data ... we removed tomcat from the test-ehr so its using something else to run and start the server under the hood now

Issue ticket number and Jira link

None - hot fix

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@zacharyrobin zacharyrobin self-assigned this Sep 8, 2023
Copy link

@zacharyrobin zacharyrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted containers and ran workflow, lgtm

@smalho01 smalho01 merged commit 6d25313 into dev Sep 8, 2023
@smalho01 smalho01 deleted the dev-environment-fix branch September 8, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants