Skip to content

Conversation

@plarocque4
Copy link

Describe your changes

Update NewRx message to include all the required header information.

Issue ticket number and Jira link

REMS-594

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@plarocque4 plarocque4 changed the title Update NewRx message to include all the required header information. Update NewRx Jan 31, 2024
Copy link

@jtquach1 jtquach1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just separating out the getting of the prescriber NPI into another function which can be called, and have its value passed into the creation of the XML NewRx Prescriber and its Identification tag

@plarocque4 plarocque4 merged commit efd4e78 into dev Feb 1, 2024
@plarocque4 plarocque4 deleted the update_newrx branch February 1, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants