make settings a modal and add save button #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeeyanGhoreshi
force-pushed
the
settings-modal
branch
from
d252704 to
ab51ab4
Compare
|
The check boxes seem to not work. For example "Send Prefetch" should default to checked but it does not. The prefetch is then included in the hook whether the box is checked or not. |
|
The UI looks nice and clean, I like it. |
KeeyanGhoreshi
force-pushed
the
settings-modal
branch
from
8c7a4e0 to
8492453
Compare
|
I'm not sure if it's just my setup, but when the page loads, there are no patients in the patient selection until you press the reload button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Pressing the settings button will now open a modal, and the settings panel now saves to localStorage, allowing persistence across sessions for desired settings.
Issue ticket number and Jira link
REMS-577
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.