Skip to content

Conversation

@avirgulto
Copy link

@avirgulto avirgulto commented Jan 24, 2024

Describe your changes

Updated patient select box to look more like the mockups. Instead of dropdowns for both medications and questionnaires have a button which opens up a table below. For the medication, in the table there is a select button that selects that medication and closes the accordian. For the questionnaire, there is a button to open the form, which opens in a new tab and then closes the accordian. The send to pharmacy and sign order buttons are still where they were before, and should work as expected.

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-576

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@plarocque4
Copy link

When the selecting only a patient and not a MedicationRequest, you have to view the list of MedicationRequests first. I think we need to have a way to select the patient without a MedicationRequest or in progress form. This is needed for launching the SMART on FHIR app with a patient context.

@plarocque4
Copy link

Perhaps the row you are hovering over for medication selection could be highlighted, and clicking anywhere on the row could select it?

@plarocque4
Copy link

When selecting an in-progress form I also didn't expect it to open immediately in a new window. This may be better but we should maybe demo this for the team after standup tomorrow. If we do it this way we shouldn't bother showing the in-progress form details in the separate box after selection. It would be nice to highlight on hover and select when clicking on the row like I suggested for the MedicationRequest.

@plarocque4
Copy link

I'd also like to get input from the team on wording on the buttons to show the medications as well.
Overall this looks and works great!

Copy link

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great

@plarocque4 plarocque4 merged commit d2d970c into dev Jan 30, 2024
@plarocque4 plarocque4 deleted the feature/576-update-workflow branch January 30, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants