Skip to content

Conversation

@plarocque4
Copy link

Describe your changes

Fix deployment to github pages and launch from meld.
Fix crash when sending to rems-admin if rems-admin does not respond.

Issue ticket number and Jira link

N/A

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

…ending to rems-admin if rems-admin does not respond.
Copy link

@avirgulto avirgulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it locally and from meld, works good.

@avirgulto avirgulto merged commit ddaabc6 into dev Jan 11, 2024
@avirgulto avirgulto deleted the deploy-fixes branch January 11, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants