Skip to content

Conversation

@zacharyrobin
Copy link

Describe your changes

Introduces Client ID Registration page (localhost:3000/register) that can be used to for registering client IDs and iss in standalone and smart launch. If testing using meld, when launching Request-Generator you will need to copy over the client id from meld settings and also in /.env you'll need to update the REACT_APP_CLIENT_SCOPES to launch openid user/*.* offline_access profile

Issue ticket number and Jira link

REMS-567

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@avirgulto avirgulto self-assigned this Jan 10, 2024
Copy link

@avirgulto avirgulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the meld launch and standalone launch and both worked as expected

@avirgulto avirgulto merged commit fcdeecb into dev Jan 10, 2024
@avirgulto avirgulto deleted the 567-client-id-registration branch January 10, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants