325 RxStatus #90
Merged
325 RxStatus #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plarocque4
reviewed
Jan 9, 2024
| console.log('Successfully sent NewRx to PIMS'); | ||
| console.log(response); | ||
| this.props.consoleLog('Successfully sent Rx to PIMS', types.info); | ||
| this.handleRxResponse(); |
There was a problem hiding this comment.
Should this check the return code, or the data that was returned to see if it was a valid RxStatus message returned?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR should be tested with branch
324-RxStatusinpims(mcode/pims#58)Potential bug noted: Its old, but addRx sends twice? I believe this is an issue we have been aware but wanted to document again.
Issue ticket number and Jira link
REMS-325
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.