Skip to content

Conversation

@jtquach1
Copy link

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

Updated documentation, removing unused auto-assign GitHub workflow, and alphabetized .env file

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

https://jira.mitre.org/browse/REMS-556

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@jtquach1 jtquach1 changed the title Rems 556 connectathon docs Update docs for Jan 2024 Connectathon Dec 27, 2023
@jtquach1 jtquach1 marked this pull request as ready for review December 28, 2023 16:33
@avirgulto avirgulto self-assigned this Dec 29, 2023
avirgulto
avirgulto previously approved these changes Dec 31, 2023
Copy link

@avirgulto avirgulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jtquach1 jtquach1 force-pushed the rems-556-connectathon-docs branch 2 times, most recently from ecf0c49 to fbd57d2 Compare January 2, 2024 22:17
@jtquach1 jtquach1 force-pushed the rems-556-connectathon-docs branch from fbd57d2 to a85279d Compare January 2, 2024 22:30
@jtquach1 jtquach1 force-pushed the rems-556-connectathon-docs branch from a85279d to 94d48fa Compare January 2, 2024 22:33
@jtquach1 jtquach1 requested a review from avirgulto January 2, 2024 22:34
@jtquach1
Copy link
Author

jtquach1 commented Jan 2, 2024

@avirgulto sorry for the giant diffs- just rebased off dev and cherry-picked/edited a bunch of commits just to get Rob's PR changes from da1baef in. The only real changes were adjusting the REACT_APP_PUBLIC_KEYS variable in the .env and updating the README.md from his PR's text

Copy link

@avirgulto avirgulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pulled down and ran and everything works as expected

@jtquach1 jtquach1 merged commit 64090f2 into dev Jan 4, 2024
@jtquach1 jtquach1 deleted the rems-556-connectathon-docs branch January 4, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants