Skip to content

Conversation

@avirgulto
Copy link

@avirgulto avirgulto commented Dec 27, 2023

Describe your changes

Updated select a patient to be accordian instead of modal. I moved the patient select to the top level to be on the home page above the left/right sides of the information. Patients endpoint is called when the page loads instead of on 'select a patient' and is not called every time you open the accordian. There is a refresh button to the right of the accordian which will re-call the endpoint pulling from the settings page field. When the settings page patientFhirQuery is updated, it will hit the endpoint again. The console box was removed from the request generator. Also, I update the text around the patient search box and added a 'showing x of x records' to better match the mockups.

To Test:

  • Go through normal workflow from request generator, selecting just a patient, selecting a medication request, and selecting in progress forms, ensuring it functions as before. Make sure network requests are getting called as expected.

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-513 and https://jira.mitre.org/browse/REMS-572

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

Copy link

@KeeyanGhoreshi KeeyanGhoreshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opening the settings puts them all below the accordion, which looks like a bug.

@avirgulto avirgulto merged commit 7da78db into dev Jan 10, 2024
@avirgulto avirgulto deleted the 513-in-page-select branch January 10, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants