Jwt keys #86
Merged
Jwt keys #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on web tokens used in cds-hooks calls
KeeyanGhoreshi
left a comment
KeeyanGhoreshi
left a comment
There was a problem hiding this comment.
Looks good, only thing I'd add is maybe a quick blurb in the readme about generating a jwt and which files to replace/edit.
Adding description for public/private keys
zacharyrobin
approved these changes
Jan 2, 2024
zacharyrobin
left a comment
zacharyrobin
left a comment
There was a problem hiding this comment.
Thanks for updating the .env, Everything else looks good on my end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR replaces the generated keys used for signing JWTs to authorize the CDS-Hooks call with pregenerated keys. These keys are included in the repository as this is meant for demonstration purposes only. Note that this does not conform to the description of the JIRA task as it was a misnomer to begin with.
Issue ticket number and Jira link
REMS-568
Please include the Jira Ticket Number and Link for this issue/task.
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.