Skip to content

Conversation

@zacharyrobin
Copy link

Describe your changes

UI changes to the to display the in progress form in a more clear manner.
Updated include

  • Use of Material UI
  • Use of Function based component vs Class based components
  • Improved component focused design
  • Separating out component from RequestBox.js file to reduce congestion and improve readability
Screenshot 2023-12-05 at 11 40 18 AM

Issue ticket number and Jira link

REMS-507)

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@plarocque4 plarocque4 self-assigned this Dec 6, 2023
@plarocque4
Copy link

After selecting a patient/medication request the display shows a strange error message where the in-progress form info was. The box should probably just be removed when no in-progress form was selected.
Please see the attached image below:
Screenshot 2023-12-06 at 3 03 42 PM

@plarocque4
Copy link

Updates look good. Could you change the background color to be the same as the main box, it looks slightly different but maybe it's just me or my monitor.
Also, could you make the background of the "OPEN IN-PROGRESS FORM" button white to match the others?

Copy link

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@zacharyrobin zacharyrobin merged commit f5aae61 into dev Dec 11, 2023
@zacharyrobin zacharyrobin deleted the 507-action-buttons branch December 11, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants