Skip to content

Conversation

@jtquach1
Copy link

@jtquach1 jtquach1 commented May 23, 2024

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

image
image

Removed code causing DOM element warning and Uncaught TypeError that was breaking the promise that POSTs the Task creation to test-ehr

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

N/A, this was randomly found post-1.0

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

How to replicate this bug

  1. Checkout main on request-generator
  2. Select Jon Snow & Turalio
  3. Click the "Send Rx" button and click the "Sign order" button
  4. Open DevTools in the Network tab
  5. Click the "Add "Completion of Patient Enrollment Questionnaire" to task list" button
  6. The network request POSTing the Task to test-ehr will not be present

@jtquach1 jtquach1 merged commit 7767522 into dev May 30, 2024
@jtquach1 jtquach1 deleted the fix-add-to-task-list-bug branch May 30, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants