Skip to content

Conversation

@jtquach1
Copy link

@jtquach1 jtquach1 commented May 20, 2024

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

Removed unused code while doing REMS-678 and looking at request-generator as a reference

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

N/A

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

How to test manually

  1. Go to settings panel
  2. e.g. For TIRF, change the order-sign endpoint URL to point to rems-patient-view at the end
  3. Open network tab
  4. Select Jon Snow & TIRF, then click sign order
  5. Notice that the rems-patient-view network request was hit and a list of cards was returned as a response

@jtquach1 jtquach1 force-pushed the remove-unused-code branch from 4613b86 to 2ace4a1 Compare May 20, 2024 14:58
@smalho01 smalho01 self-assigned this May 20, 2024
avirgulto
avirgulto previously approved these changes May 20, 2024
Copy link

@avirgulto avirgulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ran it and everything works as expected.

smalho01
smalho01 previously approved these changes May 20, 2024
@jtquach1 jtquach1 dismissed stale reviews from smalho01 and avirgulto via 7a0b266 May 20, 2024 16:16
@smalho01 smalho01 merged commit e80304b into dev May 20, 2024
@smalho01 smalho01 deleted the remove-unused-code branch May 20, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants