Skip to content

Conversation

@avirgulto
Copy link

@avirgulto avirgulto commented Apr 18, 2024

Describe your changes

Add encounter start and patient view toggle to settings page. Whichever is selected will send when the user selects a patient from the patient select section.

If you have encounter-start selected on the toggle, it will hit a 404 until this ticket is done: https://jira.mitre.org/browse/REMS-659

To Test:
Toggle between patient view and encounter start, make sure the correct one is sent via networks tab.

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-663

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

Copy link

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@plarocque4
Copy link

The label for the drop-down seems to overlap the top of the box.

Screenshot 2024-04-23 at 1 45 41 AM

@avirgulto avirgulto merged commit 14aa086 into dev Apr 24, 2024
@avirgulto avirgulto deleted the encounter-start-patient-view branch April 24, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants