Skip to content

Conversation

@zacharyrobin
Copy link

@zacharyrobin zacharyrobin commented Apr 12, 2024

Describe your changes

Updated CDS Hooks Card UI based off of mockup styling.
Old:
Screenshot 2024-04-12 at 7 52 37 AM

Updated:
Screenshot 2024-04-12 at 7 12 29 AM

Issue ticket number and Jira link

REMS-581

Checklist before requesting a review

  • [ x] I have performed a self-review of my code
  • [ x] Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@plarocque4 plarocque4 self-assigned this Apr 12, 2024
@plarocque4
Copy link

I like these changes, but perhaps we should discuss with the group.

@plarocque4
Copy link

A medication without forms should not have the headings on the returned card for "Required Forms" and "Add To Task List". Addyi is a good example of this.

Screenshot 2024-04-15 at 4 29 08 PM

@plarocque4
Copy link

Form buttons should be more square and in a row like in the mockup and should have an icon that delineates between patient and provider forms.

@plarocque4
Copy link

The form buttons should have a full arrow instead of just the '>'. This looks like it might be an accordion that can open instead of launching into something.

@plarocque4
Copy link

You might want to change the "Add to Task" text to read "Suggestions" since it might not be just tasks that are returned and displayed here.

Copy link

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to hide the document list if there are no documents available.

plarocque4
plarocque4 previously approved these changes May 17, 2024
Copy link

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@plarocque4 plarocque4 merged commit f9d5878 into dev May 20, 2024
@plarocque4 plarocque4 deleted the 579-updated-cds-hooks branch May 20, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants