Skip to content

Conversation

@jtquach1
Copy link

@jtquach1 jtquach1 commented Mar 28, 2024

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

  • Add table in settings panel for REMS drugs
  • Update Sign Order (generic submit function for patient-view, order-select, and order-sign) code to only send the order-sign hook to a particular drug's REMS admin
  • Add ability to add/delete/edit rows of REMS drugs in settings panel
  • Remove certain environment variables since there are now different REMS admin endpoints per drug and CDS hook
  • Some settings panel UI tweaks

Related PR:
mcode/rems-setup#31

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

https://jira.mitre.org/browse/REMS-644

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@jtquach1 jtquach1 marked this pull request as draft March 28, 2024 23:18
@jtquach1 jtquach1 force-pushed the rems_admins_lookup_table branch from cc5a9c0 to e533070 Compare April 1, 2024 20:52
@jtquach1 jtquach1 marked this pull request as ready for review April 1, 2024 21:24
@jtquach1
Copy link
Author

jtquach1 commented Apr 1, 2024

Videos demonstrating functionality:

Load from local storage, reset, delete, select REMS drug and click Sign Order, select non-REMS drug and click Sign Order
https://github.com/mcode/request-generator/assets/33106214/90988dd9-cba8-496c-b372-bf502ef80e4d

Delete, Load from local storage
https://github.com/mcode/request-generator/assets/33106214/b1f094da-d978-47d1-8aaa-51291fe150fa

@plarocque4
Copy link

Please merge the latest dev into this PR.

@jtquach1 jtquach1 force-pushed the rems_admins_lookup_table branch from 8cfa5ea to 4df8769 Compare April 3, 2024 19:08
@jtquach1
Copy link
Author

jtquach1 commented Apr 3, 2024

Please merge the latest dev into this PR.

Just rebased off origin/dev, I can

  1. send the order-sign hook for Turalio and get cards
  2. and also remove it to get no cards
  3. and change the endpoint to end with rems-patient-view instead of rems-order-sign, and cards come back.

and also the Turalio scenario is completable along with the ETASU and MedicationDispense statuses updating correctly

Copy link

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well

@jtquach1 jtquach1 merged commit 06bdf2e into dev Apr 3, 2024
@jtquach1 jtquach1 deleted the rems_admins_lookup_table branch April 3, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants