Skip to content

Conversation

@KeeyanGhoreshi
Copy link

adds patient portal etasu status, as well as rebasing onto dev and making the etasu component usable in both the patient portal and main view

@KeeyanGhoreshi KeeyanGhoreshi mentioned this pull request Mar 27, 2024
4 tasks
@plarocque4
Copy link

The diff has all of the VITE stuff too which makes it very hard to review.

@KeeyanGhoreshi
Copy link
Author

that's because this branch is based off #112 and also rebased onto dev. The diff looks like that because #112 is missing the commits from dev, and instead added a merge commit, so now we're out of sync. I would recommend we close #112 and just use this PR since they contain the same changes and then point this one at dev

@avirgulto
Copy link

I'm getting the 404 error when trying to login to the patient portal again, because of the /auth/ in the url for the authentication. This was resolved for me before, not sure what changed or what I should do to resolve it. Removing the 'auth' part of the url works for authentication

@avirgulto
Copy link

avirgulto commented Apr 1, 2024

Also not sure where the etasu status is in the patient portal? I went through each tab and don't see the section for it?

After looking more into it I see i'm getting a 404 when trying to get the ETASU
Screenshot 2024-04-01 at 10 54 53 AM

@KeeyanGhoreshi
Copy link
Author

Oh right, I forgot to push up the supporting branch for rems admin

mcode/rems-admin#138

Use this branch on rems admin and it should work

@avirgulto
Copy link

When the etasu is not started it doesn't show - previously it would show:
Screenshot 2024-04-02 at 10 25 15 AM

But now on this branch, there is none:
Screenshot 2024-04-02 at 10 30 46 AM

@KeeyanGhoreshi KeeyanGhoreshi changed the base branch from 645-etasu-status to dev April 2, 2024 19:50
@KeeyanGhoreshi KeeyanGhoreshi force-pushed the etasu-status-patient-portal branch from 76d2110 to f0f4be7 Compare April 2, 2024 20:04
Copy link

@avirgulto avirgulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@avirgulto avirgulto merged commit 492d1b0 into dev Apr 3, 2024
@avirgulto avirgulto deleted the etasu-status-patient-portal branch April 3, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants