Skip to content

Conversation

@avirgulto
Copy link

@avirgulto avirgulto commented Mar 7, 2024

Describe your changes

Refactor request-generator to react functional components instead of classes. Also removed the Input files since they weren't used anymore after moving to mui checkboxes/inputs/etc.

To test:
Ensure everything still works as expected

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-540

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@jtquach1
Copy link

jtquach1 commented Mar 8, 2024

Besides the settings panel, I don't see any bugs when doing scenario 1 with Turalio. That includes saving the patient enrollment form, loading from the patient select dropdown, sending the Rx, signing the order, clicking the MedicationDispense.status button, going into the patient portal and finding the patient enrollment form. Nice job!

@avirgulto avirgulto requested a review from jtquach1 March 8, 2024 20:49
@avirgulto avirgulto merged commit 89c1734 into dev Mar 13, 2024
@avirgulto avirgulto deleted the 540-functional-components branch March 13, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants