Skip to content

Conversation

@KeeyanGhoreshi
Copy link

Describe your changes

Allow tasks to launch and change their status in the task view.

Issue ticket number and Jira link

REMS-606

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

@avirgulto avirgulto self-assigned this Mar 4, 2024
@plarocque4
Copy link

Can we show who the task is assigned to in the UI?

@plarocque4
Copy link

Can you update the patient portal tasking:

  1. Remove the "View Resource" button,
  2. Add the status drop-down
  3. Make the "Process Task" button work to launch the smart app

@plarocque4 plarocque4 self-assigned this Mar 7, 2024
@KeeyanGhoreshi
Copy link
Author

the task is already showing who it is assigned to in the UI, I'm not sure if you mean something else.

@avirgulto
Copy link

This is probably either a future ticket or out of scope but do we want to disable the process task button if it isn't assigned to the user, or if the status is 'on-hold' or 'cancelled' or 'completed'? Also, once a task is done and marked as completed, do we want them to be placed in a different spot? Like maybe having a tab that is open tasks and then all tasks will have all of them, where open would only have not completed tasks.

@KeeyanGhoreshi
Copy link
Author

all of these are good suggestions, but they ought to be a different ticket. As it stands, I don't think improved task functionality is a high priority of ours.

@plarocque4
Copy link

I see now that the assignee is listed, I didn't see it before, ignore that comment.

@plarocque4
Copy link

The patient portal is not working with the new changes though. This may be out of scope of this PR, but the patient portal is already working with viewing tasks, just not launching them like this task achieves. I can write another ticket for that if you think it is necessary.

@plarocque4
Copy link

Can you also please merge the latest into your branch. I believe that the changes @avirgulto made might make this tricky.

Copy link

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@plarocque4 plarocque4 merged commit 7425741 into dev Mar 18, 2024
@plarocque4 plarocque4 deleted the task-launch branch March 18, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants