Fix medication dispense flicker #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyrobin
previously approved these changes
Feb 23, 2024
zacharyrobin
left a comment
zacharyrobin
left a comment
There was a problem hiding this comment.
Bug fix worked on my end, tested with a few medications
KeeyanGhoreshi
previously requested changes
Feb 23, 2024
jtquach1
force-pushed
the
fix-medication-dispense-flicker
branch
from
0663644 to
2a54855
Compare
…age is empty, the dispatch will never happen
Author
|
after rebasing off dev and dispatch commit: |
jtquach1
dismissed
KeeyanGhoreshi’s stale review
pushed up commit addressing review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The MedicationDispense.status button flashes with the N/A state and the color black before the fetch to test-ehr resolves with the real MedicationDispense.status, which may be a status of "Picked up" and the color green.
Before
Screen.Recording.2024-02-22.at.12.02.21.AM.mov
After
Screen.Recording.2024-02-22.at.12.02.00.AM.mov
Issue ticket number and Jira link
https://jira.mitre.org/browse/REMS-622
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.