Skip to content

Conversation

@avirgulto
Copy link

@avirgulto avirgulto commented Feb 21, 2024

Describe your changes

I noticed the 'submitted new Rx' snackbar stopped showing up. After looking at it, it seems the state variable that controls opening the snackbar got changed (from open to submittedRx) but the places where the variable was set to true was still setting 'open' and not 'submittedRx'.

To Test:
Clear out PIMs and send new Rx to pharmacy, should see green snackbar at the bottom saying "Sucess! NewRx received by pharmacy'

Issue ticket number and Jira link

Small bug discovered - no JIRA ticket

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@plarocque4 plarocque4 self-assigned this Feb 21, 2024
Copy link

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well

@plarocque4 plarocque4 merged commit 063808f into dev Feb 23, 2024
@plarocque4 plarocque4 deleted the fix-snackbar-bug branch February 23, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants