-
Notifications
You must be signed in to change notification settings - Fork 1
Task UI #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5075b6a to
6db69b6
Compare
|
I don't see the Reconnect EHR button, do we need to add it back? |
|
Can we make the buttons in the Task Management tab all the same height? |
f0586b3 to
c145188
Compare
jtquach1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to comment on these files (there's some redundant code)
jtquach1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
realized I did not check on the Task UI, but I think the styling looks good to me with one minor suggestion
e0ed32b to
772615f
Compare



Describe your changes
This PR includes a lot of changes to the request generator, including the tickets' original goal of creating a UI to view/manage tasks. Actually being able to interact with the tasks will be handled in a different ticket.
I've also overhauled the UI to support several different views, instead of modals for everything, since we'd be entering the territory of modals inside modals continuing on the path we were on. The settings have been made a separate tab and I've rewritten the component to use react hooks.
The app now supports a top down context using react's
useContext, which means that components can now access and update a 'global' state instead of passing information down through props and changes back up through callbacks. This can be used in the future for other variables that need to be available to the whole app.Issue ticket number and Jira link
REMS-605
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review