Skip to content

Conversation

@KeeyanGhoreshi
Copy link

Describe your changes

This PR includes a lot of changes to the request generator, including the tickets' original goal of creating a UI to view/manage tasks. Actually being able to interact with the tasks will be handled in a different ticket.

I've also overhauled the UI to support several different views, instead of modals for everything, since we'd be entering the territory of modals inside modals continuing on the path we were on. The settings have been made a separate tab and I've rewritten the component to use react hooks.

The app now supports a top down context using react's useContext, which means that components can now access and update a 'global' state instead of passing information down through props and changes back up through callbacks. This can be used in the future for other variables that need to be available to the whole app.

Issue ticket number and Jira link

REMS-605

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

@plarocque4
Copy link

I don't see the Reconnect EHR button, do we need to add it back?

@plarocque4
Copy link

Can we make the buttons in the Task Management tab all the same height?

@KeeyanGhoreshi
Copy link
Author

image
all the buttons should be the same height, unless the screen width pushes them to take up 2 lines. I could make the button descriptors all 1 word if that would help.

@avirgulto
Copy link

avirgulto commented Feb 19, 2024

I've gotten myself into a error loop that seems to crash the application. I tried to test out the new settings section to search for only one patient, so I updated the settings section to be Patient?_sort=identifier&_count=12&id=pat017 without the correct _id and I would only see the small text for 'loading...'. [See picture] Screenshot 2024-02-19 at 1 02 13 PM
We should probably have a better error state displayed (which can be a future ticket).

But then to fix it I added in the correct Patient?_sort=identifier&_count=12&_id=pat017 which returns a patient in the network tab, but an error is happening on render where it can't read .name of a patient so its getting process error out [see picture],
Screenshot 2024-02-19 at 1 08 51 PM
I try to reload the page and quickly go to settings page to change it back or something, but it errors out before I can do anything. Only way to fix it was to delete my local storage that stored my updated value to reset back to normal.

After trying to reproduce, it seems whenever I try to just search by id for patient search it gets this error and gets back into the loop mentioned above.

Copy link

@jtquach1 jtquach1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to comment on these files (there's some redundant code)

Copy link

@jtquach1 jtquach1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realized I did not check on the Task UI, but I think the styling looks good to me with one minor suggestion

@avirgulto avirgulto merged commit ae38636 into dev Feb 23, 2024
@avirgulto avirgulto deleted the task-ui branch February 23, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants