Skip to content

Conversation

@jtquach1
Copy link

@jtquach1 jtquach1 commented Feb 14, 2024

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

Dependencies/related tasks

Run alongside mcode/test-ehr#67
Related to mcode/rems-smart-on-fhir#72 but not necessary to pull in to review at same time (uses same UI elements from dev)

Summary of changes

  • Ported over MedicationDispense check from rems-smart-on-fhir
  • Made spacing/styling changes to RequestBuilder.js (nav bar and content below nav bar)

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

https://jira.mitre.org/secure/RapidBoard.jspa?rapidView=4984&projectKey=REMS&view=detail&selectedIssue=REMS-597

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@jtquach1 jtquach1 force-pushed the read-dispensed-status-from-ehr branch 16 times, most recently from 80fda26 to 455f739 Compare February 16, 2024 18:48
@jtquach1 jtquach1 force-pushed the read-dispensed-status-from-ehr branch from 455f739 to a5ec438 Compare February 16, 2024 18:53
@jtquach1
Copy link
Author

jtquach1 commented Feb 16, 2024

After styling changes:
image
image
image
image
image

States: N/A and Picked Up

@jtquach1 jtquach1 marked this pull request as ready for review February 16, 2024 18:57
@jtquach1 jtquach1 force-pushed the read-dispensed-status-from-ehr branch from 6d20cb5 to 1c717bd Compare February 16, 2024 19:05
Copy link

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@plarocque4 plarocque4 merged commit 5e31c9d into dev Feb 19, 2024
@plarocque4 plarocque4 deleted the read-dispensed-status-from-ehr branch February 19, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants