Skip to content

Conversation

@smalho01
Copy link
Contributor

@smalho01 smalho01 commented Oct 16, 2024

Describe your changes

docker configs for inermediary and rems admin configs

e2e test run: https://github.com/mcode/rems-setup/actions/runs/11481903830/job/31953681554

How to test: Run the ci/cd pipeline according to the configuration below, also pull the same branches locally and ensure everything still works


Screenshot 2024-10-23 at 10 04 12 AM

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-763, https://jira.mitre.org/browse/REMS-759

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@smalho01 smalho01 changed the title env configs for intermediary + rems admin env configs for intermediary + rems admin + pims + request generator Oct 23, 2024
Copy link
Contributor

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@smalho01 smalho01 merged commit f0722be into dev Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants