Skip to content

Conversation

@dmendelowitz
Copy link
Contributor

Summary

clinicalSiteSystem can now be specified in the config file, similar to how clinicalSiteID is, except clinicalSiteSystem is optional

New behavior

If a clinicalSiteSystem is added to the constructorArgs of CSVClinicalTrialInformationExtractor in the config file, that value will be used for the system field of the site object in the ResearchStudy resource. If no system is specified, the system field will be omitted in the output.

Code changes

  • CSVClinicalTrialInformationExtractor.js now takes an optional clinicalSiteSystem constructor argument and adds that to the formatted data for the Research Study
  • ResearchStudyTemplate.js now takes an input for clinicalSiteSystem instead of just using an example.com value
  • CSVClinicalTrialInformationExtractor.test.js and researchStudy.test.js have been updated to reflect the above changes

Testing guidance

  • Add a value for clinicalSiteSystem to the constructor arguments of the CSVClinicalTrialInformationExtractor and see that the correct value appears in the output and that there is no system in the output if the argument is removed from the config
  • Make sure the new tests pass and accurately test the new functionality

Copy link
Contributor

@julianxcarter julianxcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mgramigna mgramigna self-assigned this Apr 1, 2021
@mgramigna mgramigna merged commit bd8adec into develop Apr 1, 2021
@mgramigna mgramigna deleted the add-clinical-site-system branch April 1, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants