Improving dataDirectory approach #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dtphelan1
requested review from
dmendelowitz,
jafeltra,
julianxcarter and
mgramigna
as code owners
Dtphelan1
force-pushed
the
data-directory-round-2
branch
from
2e2bd56 to
900b9bf
Compare
jafeltra
approved these changes
Dec 17, 2021
Contributor
jafeltra
left a comment
jafeltra
left a comment
There was a problem hiding this comment.
Looks good! Thanks for working through that with me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better error messaging in the event that someone expects the DataDirectory to inform the patientIdCsv read operation