Support for new simple extensions added to the CTC AE Extractor #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianxcarter
requested review from
Dtphelan1,
dmendelowitz,
jafeltra and
mgramigna
as code owners
dmendelowitz
requested changes
Dec 9, 2021
Contributor
dmendelowitz
left a comment
dmendelowitz
left a comment
There was a problem hiding this comment.
This looks really good! My only comment is that I think it would be good to update the tests for the template in ctcAdverseEvent.test.js and it's related fixtures
Contributor
Author
|
Knew I was missing something! Thanks for the heads up on that @dmendelowitz 🙂 |
dmendelowitz
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the resolvedDate, expectation, and seriousnessOutcome extensions to the CTC AE Extractor. Also adds new valueSet helper functions.
New behavior
The CTC AE Extractor now extracts values for the three optional simple extensions found on the CTC AE resource.
Code changes
valueSetUtils.js;getConceptFromVSExpansionandgetConceptFromVSComposereturn a concept from the respective parts of a ValueSet, andgetDisplayFromConceptreturns the displayText of a given concept from a valueSet when provided the code and codeSystem of that concept.CSV_Templates.xlsxanddocs/ctc-adverse-event.csv.Testing guidance
Ensure unit tests pass, and that running the framework with the new values present in a CSV results in a valid CTC AE resource.