Adding event.coding.version and event.text to CTCAE Extractor #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmendelowitz
requested review from
Dtphelan1,
jafeltra,
julianxcarter and
mgramigna
as code owners
Contributor
Author
|
Turns out event.text is not required, so disregard anything said above about it being required |
|
|
||
| const MINIMAL_DATA = { | ||
| // Only include 'id', 'subjectId', 'code', 'system', 'grade', and 'effectiveDateTime' fields which are required | ||
| // Only include 'id', 'subjectId', 'code', 'system', 'text', 'grade', and 'effectiveDateTime' fields which are required |
Contributor
There was a problem hiding this comment.
Super tiny, I think we can remove text from this comment right here now that it's no longer required.
Contributor
julianxcarter
left a comment
julianxcarter
left a comment
There was a problem hiding this comment.
Looks great and works well! Just two minor suggestions.
|
|
||
| const INVALID_DATA = { | ||
| // Omitting 'subjectId', 'code', 'system', and 'effectiveDateTime' fields which are required | ||
| // Omitting 'subjectId', 'code', 'system', 'text', and 'effectiveDateTime' fields which are required |
julianxcarter
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional version field for the event coding and a required text field for the event of the CSVCTCAdverseEventExtractor
New behavior
The CSV template for the CSVCTCAdverseEventExtractor now has a new required field of
adverseEventTextand a new optional fieldadverseEventCodeVersionCode changes
CTCAdverseEventTemplate.jsmodified to add the new fieldsCSVCTCAdverseEventExtractor.jsmodified to have the new fields in the CSV template and check for new required fieldCSV_Templates.xlsxchanged to have new fieldsTesting guidance