Skip to content

Conversation

@dmendelowitz
Copy link
Contributor

Summary

This PR removes severity and fixes the value of actuality to 'actual' in the output of the CTCAdverseEventExtractor

New behavior

Severity is no longer in the CSV template and is removed from the output of the client. Actuality is removed from the CSV template but will always have the fixed value of 'actual' in the output

Code changes

  • Severity and actuality removed from CSVCTCAdverseEventExtractor.js
  • CTCAdverseEventTemplate.js updated to have severity removed and actuality fixed to 'actual'
  • Related tests and test fixtures updated to reflect the changes
  • All sample CSVs and CSV_Templates.xlsx updated to reflect changes

Testing guidance

  • Run the client with the CTC-AE Extractor and see that severity is no longer present in the output and that actuality always has the value of 'actual'
  • Ensure that all tests still pass and that the updated tests correctly reflect the changes

Copy link
Contributor

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I couldn't think of any places you missed or any other tests to add!

@jafeltra jafeltra merged commit d8465ab into develop Nov 30, 2021
@jafeltra jafeltra deleted the remove-ae-fields branch November 30, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants