dateTimeStamp now localizes to UTC #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dtphelan1
requested review from
dmendelowitz,
jafeltra,
julianxcarter and
mgramigna
as code owners
Contributor
Author
|
Whoops this breaks more than it fixes – pushing up a more careful version of this change later 😄 |
Dtphelan1
changed the title
Dtphelan1
changed the title
jafeltra
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addressing the root cause of broken E-MEF PerformanceStatus tests, we realized that the failing tests were due to the fact that our formatDateTime function was always interpretting timestamps according to the local timezone. This is according to the
moment()constructor specification found here. Also found in the moment parsing documentation is guidance on themoment.parseZone()function, which will maintain the provided timezone in the parsing of a string and default to UTC if none is provided.This PR updates our use of moment in our formatDate functions to use this newly discovered method, leading to more robust testing fixtures on the E-MEF that don't depend on a testing machine running in the Eastern Time Zone