Creating new mask field 'genderAndSex' which masks all related fields #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmendelowitz
requested review from
Dtphelan1,
jafeltra,
julianxcarter and
mgramigna
as code owners
jafeltra
reviewed
Oct 26, 2021
Contributor
jafeltra
left a comment
jafeltra
left a comment
There was a problem hiding this comment.
This looks really good and I tested it with the E-MEF and everything is masked as expected now! I just had one suggestion to add to the tests. Let me know what you think.
| const bundle = _.cloneDeep(examplePatient); | ||
| maskPatientData(bundle, [ | ||
| 'gender', | ||
| 'genderAndSex', |
Contributor
There was a problem hiding this comment.
I think it might be good to include thew two new extensions that genderAndSex now mask on the examplePatient bundle, and then include the masked properties in the exampleMaskedPatient, just to ensure we don't accidentally break the masking of these fields in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous mask fields of 'gender' and 'birthSex' have been merged into a new 'genderAndSex' mask field which masks both as well as the legal sex and sex for clinical use fields used by Epic.
New behavior
Gender, birth sex, legal sex and sex for clinical use are now all masked by a single option, 'genderAndSex'
Code changes
maskPatientData()have been replaced with 'genderAndSex' which masks all sex and gender related fields (gender, birthsex, legal sex, and sex for clinical use)patientUtils.test.jsupdated to work with the new fieldsTesting guidance