-
Notifications
You must be signed in to change notification settings - Fork 2
"all" option for Patient masking now supported in the config #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jafeltra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! The only thing I thought of is if there is a test we could add to ensure that a provided 'all' value masks values, but I couldn't think of where that fit in with any of our existing tests since you reused the maskPatientData field so well!
|
It looks like this just needs a rebase and then it should be good to be merged! |
b25d326 to
89f141e
Compare
|
I spoke with @jafeltra and we both thought it made a bit more sense to localize this change to the |
|
The changes here look really good! The only thing that I think might be off is the commits. It seems like there are a lot more commits than expected after the rebase. Did you maybe rebase off of |
11d5557 to
2c9f89a
Compare
2c9f89a to
ec7ef8c
Compare
|
That's exactly what I did, the git weirdness should be fixed now! |
jafeltra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I really like the refactor and masterful git work!
Summary
Adds support for a string value of
allwithin the Patient Extractor constructorArgs.New behavior
A string with a value of
allcan now be included in the Patient Extractor config to mask all supported Patient fields.Code changes
config.schema.jsonhas been updated to allow both strings and arrays.configUtils.jsto validate that any string included in themaskfield is theallflag.allflag added to theFHIRPatientExtractorandCSVPatientExtractor.Testing guidance
allflag in the config actually masks all properties.maskproperty in the config causes config validation to fail.