Skip to content

Conversation

@Dtphelan1
Copy link
Contributor

@Dtphelan1 Dtphelan1 commented Sep 29, 2021

Summary

Below are all the major utils-related concepts checked for changes across STU1 to STU2. These lists of questions are based on the responsibilities of the utils files (listed below) identified by the task. Conclusions are based on the May2021 STU2 specification described here: http://hl7.org/fhir/us/mcode/2021May/index.html

Files checked:

  • src/helpers/cancerStagingUtils.js
  • src/helpers/conditionUtils.js
  • src/helpers/diseaseStatusUtils.js
  • src/helpers/observationUtils.js
  • src/helpers/patientUtils.js

Key concepts checked, along with their change/no change status:

Testing guidance

  • Ensure that tests still pass and changes align with the new VS values
  • Ensure that I didn't miss any areas of these files in my review. If I did, let me know what other aspects of the identified utils files I should inspect 😄

@Dtphelan1 Dtphelan1 changed the base branch from main to develop September 29, 2021 14:54
@julianxcarter julianxcarter self-assigned this Sep 29, 2021
Copy link
Contributor

@julianxcarter julianxcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks good to me! I've done a sanity check to ensure that the bits you've identified that don't need changes don't in fact need changes, and also that values that do need changes have been changed appropriately. I don't think you've missed anything. I just had one minor comment (about a comment) and I think this is ready to merge.

@@ -1,8 +1,8 @@
const { createInvertedLookup, createLowercaseLookup } = require('../lookupUtils');

// Code mapping is based on current values at http://standardhealthrecord.org/guides/icare/mapping_guidance.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JC1: I think we should probably update the link in this comment to point to https://www.hl7.org/fhir/us/mcode/2021May/ValueSet-mcode-condition-status-trend-vs.html

@Dtphelan1
Copy link
Contributor Author

Addressed your feedback @julianxcarter 😄

Copy link
Contributor

@julianxcarter julianxcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks good to me 👍🏽

@julianxcarter julianxcarter merged commit 4075b87 into develop Oct 1, 2021
@julianxcarter julianxcarter deleted the stu2/utils branch October 1, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants