-
Notifications
You must be signed in to change notification settings - Fork 2
CancerRelatedMedication STU2 Updates #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jafeltra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great! All the changes in the code and the new fields in the extractor look correct to me! I ran the FHIR validator against the output and found a few things we might want to update in our sample data, so I left a few comments related to that, along with just a couple quick general comments.
JA1 - The src/index.js file should be updated similarly to the src/extractors/index.js file to include the new extractors.
JA2 - Can you update the csv.config.example.json file to use the two new extractors instead of the one old one?
JA3 - It looks like the status values for MedicationAdministration are different than they were for MedicationStatement. The options it can be are in this valueset. Do you think you could update the values we have in the sample-client-data CSV just so they reflect the expected values?
JA4 - Similar to above, the values for the reasonCode in the MedicationAdministration don't seem to match up with codes in the current Cancer Disorder Value Set. Could you update the values in our sample data fields to match codes in that value set?
JA5 - Pretty much the same as JA4, but the reasonCode for the MedicationRequest in the sample CSV also doesn't match a code in the current value set. Can you update that as well?
…nAdministrationExtractor and adding new CancerRelatedMedicationRequestExtractor
|
This looks great Dylan! In addition to the comments Julia made: |
ce572f5 to
e828c51
Compare
|
DP4 - For some of the common template snippets – |
…ippets, minor changes to tests
jafeltra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! All the JAs are resolved! The one last thing that I noticed is that I don't think you need to add the ~$CSV_Templates.xlsx file. I think the regular file is sufficient.
jafeltra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Dtphelan1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me Dylan – addresses all the comments I made eariler. Great work Dylan!
Summary
CancerRelatedMedicationExtractor has been converted to CancerRelatedMedicationAdministrationExtractor and a new CancerRelatedMedicationRequestExtractor has been added.
Profiles:
https://build.fhir.org/ig/HL7/fhir-mCODE-ig/branches/master/StructureDefinition-mcode-cancer-related-medication-request.html
http://hl7.org/fhir/us/mcode/2021May/StructureDefinition-mcode-cancer-related-medication-administration.html
New behavior
CancerRelatedMedicationAdministrationExtractor behaves the same as the old CancerRelatedMedicationExtractor. It's pretty much just a renaming. CancerRelatedMedicationRequestExtractor is a new extractor based on the profile from STU2 linked above.
Code changes
CancerRelatedMedicationExtractor(the extractor, template and tests) have been renamed toCancerRelatedMedicationAdministrationto distinguish them fromCancerRelatedMedicationRequestCancerRelatedMedicationRequestprofileMCODEClient.js,index.jsandResourceGenerator.jsupdated to support the new and renamed extractorscancer-related-medication-request-information.csvand renamedcancer-related-medication-administration-information.csvTesting guidance