Moving config file parsing from app to CLI #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rather than pass the config file path to
mcodeApp, the config will now be parsed in the CLI and passed to the app as an object.New behavior
The client should behave as before
Code changes
configValidator.jstoconfigUtils.jsand movedgetConfig()fromapp.jsto therepathToConfigargument ofmcodeApptoconfigand removed config parsing from that filegetConfig()call tocli.js, the result is then passed intomcodeAppgetConfig()moved fromapp.test.jsto the newly renamed 'configUtils.test.js'Testing guidance