Adding email with name custom schema format #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmendelowitz
requested review from
Dtphelan1,
jafeltra,
julianxcarter and
mgramigna
as code owners
dmendelowitz
force-pushed
the
email-with-name-schema
branch
from
cdf6c64 to
9989ea6
Compare
Dtphelan1
reviewed
Jul 6, 2021
Contributor
|
Beyond my one small nitpick, this looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
notificationInfo.fromnow uses a custom format for emails with a name in front of them. This format considers anything that ends with a valid email to be valid, for example:Example Name [email protected]New behavior
Config validator has a new custom format that splits the input on spaces and checks that the last element is a valid email.
Code changes
configValidator.jsnow has new custom formatemail-with-namedescribed aboveconfig.schema.jsonupdated to use new format fornotificationInfo.fromTesting guidance
Cases to test:
Any number of words followed by [email protected]should be valid[email protected]should be validWords with no emailshould not be valid[email protected] then some wordsshould not be valid