Moving MRN masking to maskPatientData #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmendelowitz
requested review from
Dtphelan1,
jafeltra,
julianxcarter and
mgramigna
as code owners
Dtphelan1
approved these changes
Jul 1, 2021
Contributor
Dtphelan1
left a comment
Dtphelan1
left a comment
There was a problem hiding this comment.
This looks great! Nice work Dylan 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that other extractors get the Patient ID from context, MRN can just be masked during extraction instead of at the end of extraction and the masked ID will propagate to all other resources.
New behavior
Behavior should be the same as before
Code changes
app.jsmaskMRN()removed frompatientUtils.jsmaskPatientData()updated to replaceidandfullUrlwith hashed version of MRNpatientUtils.test.jsupdated to reflect changesTesting guidance
Add
"mask": ["mrn"]toconstructorArgsof the Patient extractor and see that all instances of the MRN used as an ID are replaced with the hashed version of the MRN (appears in Patient'sidandfullUrlfields andsubjectorindividualreferences in other resources)