Add initial schema for one config property #127
Merged
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgramigna
requested review from
Dtphelan1,
dmendelowitz,
jafeltra and
julianxcarter
as code owners
Contributor
|
This looks really good to me! Thanks Matt for putting this together. 🚀 |
Dtphelan1
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a basic schema for our csv config. Note: This schema is not complete. We just wanted a simple skeleton in here that we can expand on. This will allow us to parallelize some of the work of authoring the rest of the schema and using said schema in the app to report errors.
New behavior
N/A
Code changes
Added a schema file that will later be used for extractor config.
Testing guidance
Head over to https://www.jsonschemavalidator.net/s/awUd23pG. This is an online playground that should have the schema from this PR and some sample content in the web. Try removing the "extractors" property which I've marked as required, or try removing the "type" property from an entry in the extractors array, which I've also marked required.
Just make sure the schema makes sense, can be built on, and works with some simple test cases in the online playground.