Skip to content

Conversation

@mgramigna
Copy link
Contributor

Summary

Add a re-usable helper in a new appUtils file that parses a provided CSV path for mrn column to iterate through patient IDs during extraction.

I want to make sure the approach for this is solid before putting up a bunch of PRs on other repos.

New behavior

None

Code changes

  • New helper that does the parsing
    • Throws error if missing a required column or if file isn't found
    • Added to index.js exports
  • Update app.js to use new helper
  • Unit tests

Testing guidance

Run usual checks and extraction. Output should be the same as it was prior, as we should be getting the same MRNs as before.

@Dtphelan1
Copy link
Contributor

lol the BOM: true got dropped in Julian's PR. whoooppppsss.......
Add that back plz?

@Dtphelan1
Copy link
Contributor

Otherwise I think this looks plenty good and you should consider this conditionally approved by me. HAGS 🏖

@Dtphelan1 Dtphelan1 self-assigned this May 27, 2021
@mgramigna
Copy link
Contributor Author

lol the BOM: true got dropped in Julian's PR. whoooppppsss.......
Add that back plz?

The PR title: "Add helper for parsing patient CSV ids with BOMs"

Phelan:
image

@dmendelowitz dmendelowitz self-assigned this May 28, 2021
Copy link
Contributor

@dmendelowitz dmendelowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I just had one small comment.

@mgramigna mgramigna merged commit 40f75a5 into develop Jun 2, 2021
@mgramigna mgramigna deleted the patient-csv-util branch June 2, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants