process.exit moved to cli.js #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Delegates fatal error handling to the cli, rather than the
mcodeApp.New behavior
When a fatal error is encountered in the
mcodeApp, the running process is now closed from the cli rather than from within the app. The cli also handles any logging that will result from that error.Code changes
cli.js, a newrunApp()function is introduced. This function calls themcodeApp()function from within atryblock. If an error is encountered, this function will log the error and exit the node process. TherunApp()function was necessary due tomcodeApp()being an asynchronous function, as calling anasyncfunction within atry..catchblock can only be done from within anasyncfunction.app.js, all fatal error handling withinmcodeApp()has been removed. Errors are now thrown straight to therunApp()function where they are logged and the process is exited.Testing guidance
npm start.npm start -- --entries-filter --from-date 54849/382/3742, as this will trigger an error due to the invalid date.