Add BOM flag to Patient ID CSV parsing #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmendelowitz
requested review from
Dtphelan1,
jafeltra,
julianxcarter and
mgramigna
as code owners
Dtphelan1
approved these changes
May 19, 2021
Contributor
Dtphelan1
left a comment
Dtphelan1
left a comment
There was a problem hiding this comment.
We're so good at software development 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The patient IDs CSV is parsed in
app.jsrather than inCSVModule.jslike the other CSVs and we forgot to add the BOM flag to that instance of the parse function being calledNew behavior
BOMs are now handled when parsing the Patient IDs CSV
Code changes
The call to the CSV parse function in
app.jsnow has the flag to properly handle BOMsTesting guidance
To test that this works, you can go and replace the
fs.readFileSync()call on line 87 ofapp.jswith the following'\uFEFFmrn\n123\n456\n789\n1011'(the same as the sample client data but with a BOM added at the start). The client should still run as expected.