Skip to content

Conversation

@dmendelowitz
Copy link
Contributor

Summary

Each sheet in the CSV_Templates excel file now links to pages with information on relevant FHIR resources to that csv template

Testing guidance

Check that the links on each sheet are the correct and make sure I didn't leave any out. Also let me know if you have issues with the formatting, I based it on what was already there in the Adverse Event sheet.

@jafeltra jafeltra self-assigned this Apr 22, 2021
@jafeltra
Copy link
Contributor

This looks great! I think the one link I'd recommend updating is the one in CancerPatient. The other links use the released STU1 mCODE links, rather than the build.fhir.org links, which update as the mCODE repo updates before balloting. So the CancerPatient link should be http://hl7.org/fhir/us/mcode/StructureDefinition-mcode-cancer-patient.html. All the others look correct!

Copy link
Contributor

@julianxcarter julianxcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes look good to me, apart from the CancerPatient sheet that @jafeltra referenced. We should also probably delete that ~$CSV_Templates.xlsx file that was saved as well. Every time you make a change to the file excel will auto-save that to the repo, so we'll need to manually delete it before the next commit.

Copy link
Contributor

@julianxcarter julianxcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@julianxcarter julianxcarter self-assigned this Apr 23, 2021
Copy link
Contributor

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@jafeltra jafeltra merged commit 3e0dc3a into develop Apr 26, 2021
@jafeltra jafeltra deleted the csv-templates-reference-fhir branch April 26, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants