CSV Module now ignores BOMs #107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the CSV Module to read csvs with invisible Byte Order Marks at the beginning of a file.
New behavior
The extractor now runs as expected when csvs containing a client's data include Byte Order Marks at the beginning of the file.
Code changes
parsefunction that's run in the CSVModule's contractor now has thebomflag set to true, causing any BOMs at the beginning of the csv to be ignored.example-csv-bom.csvfile has been added as a test fixture. It's identical to the preexistingexample-csv.csvfile, except it include a BOM at the beginning of the file.CSVModule.test.jsTesting guidance
Commit
3dd1055adds both an example csv with a BOM as well as a unit test that attempts to parse this CSV. Thebomflag has not been added in this commit though, so you should see this unit test fail as the CSVModule fails to recognize themrncolumn. In commit0e3d63a, that same unit test should pass as that commit enables thebomflag.