Loosen required fields for Patient CSV and mark missing required fields #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafeltra
requested review from
Dtphelan1,
dmendelowitz,
julianxcarter and
mgramigna
as code owners
Dtphelan1
approved these changes
Apr 14, 2021
Contributor
Dtphelan1
left a comment
Dtphelan1
left a comment
There was a problem hiding this comment.
LGTM great work the tests you describe in the other PR operate as expected here 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just updates the MEF version so that the Base ICARE client also relaxes the requirements in the patient CSV. It should be sufficient to use the same test cases as in the equivalent MEF PR (here).
Only needs one reviewer.