Add iOS support #837
Closed
Add iOS support #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Merged
|
Thanks @freakboy3742, as I already had this branch locally - as mentioned in cibuildwheel when the feature was implemented - I just used what I had instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configuration changes to support building iOS wheels.
While working on iOS packaging in cibuildwheel, I've been using pybase64 as an example of a simple binary package with a CMake build system. I figured I might as well contribute the changes needed to support iOS upstream.
This requires the in-development changes from pypa/cibuildwheel#2317. Assuming that PR is accepted, those changes won't become available any earlier than cibuildwheel 3.0. This PR presumptively bumps the cibuildwheel reference in the build-upload workflow to use that (as yet unreleased) version.