Master won't build on macOS

[whereswaldon]

Commit 2659912 fails to build on macOS 10.13.6

I discovered this while trying to build from master to report a different problem. I'll link that issue once I finish creating it.

Steps

1. brew install asciidoc
2. Clone the repo, cd into src
3. make
4. make install

Outcome

$ make install
ln -sf kak.opt kak
a2x --no-xmllint -f manpage ../doc/kak.1.asciidoc
a2x: ERROR: "xsltproc"  --stringparam callout.graphics 0 --stringparam navig.graphics 0 --stringparam admon.textlabel 1 --stringparam admon.graphics 0  "/usr/local/Cellar/asciidoc/8.6.10_1/etc/asciidoc/docbook-xsl/manpage.xsl" "/Users/waldon/Code/builds/kakoune/doc/kak.1.xml" returned non-zero exit status 5
make: *** [../doc/kak.1.gz] Error 1

Expected

Successful build.

Versions

$ a2x --version
a2x 8.6.10

[ekie]

try setting the following before running make install:

export XML_CATALOG_FILES=/usr/local/etc/xml/catalog

this seems not to be a issue limited to macOS, see #954 for reference.

the recommended way for installing kakoune is to use homebrew or linuxbrew on macOS, and the package maintainer will hopefully keep the package updated. if you build kakoune from source and install by hand you have to take care of dependencies and a correct shell environment.

[whereswaldon]

That absolutely does fix it, thank you! I've built it many times from source before and never encountered this problem, so I mistakenly assumed that it was new. I've created a wiki page with build tips to document this:
https://github.com/mawww/kakoune/wiki/Tips-for-building-from-source
Thanks again!